Add an extra cleanup task for sessions stuck in canceling state #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaffney
requested changes
Jun 22, 2022
internal/db/schema/migrations/oss/postgres/35/01_cleanup.up.sql
Outdated
Show resolved
Hide resolved
mgaffney
previously approved these changes
Jun 23, 2022
See the comment on the migrations file for details.
jefferai
force-pushed
the
jefferai-extra-session-cleanup
branch
from
54fc60b to
30c55ac
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the comment on the migrations file for details.
Note: in discussion with @mgaffney there didn't seem to be much use in creating a test for this; it's by definition corrupt data. However, in my home Boundary cluster, this query effectively identifies and removes the stuck sessions, both in the case that they are not terminated in the warehouse (in which case they are marked terminated and removed after an hour) and in the case that they are (in which case they are immediately removed).