Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade configutil dependency #2239

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Conversation

johanbrandhorst
Copy link
Collaborator

@johanbrandhorst johanbrandhorst changed the title fix: Upgrade configutil dependency Upgrade configutil dependency Jun 28, 2022
@johanbrandhorst johanbrandhorst force-pushed the jbrandhorst-bump-configutil branch from da35d31 to 03536a8 Compare June 28, 2022 18:54
tmessi
tmessi previously approved these changes Jun 28, 2022
Copy link
Member

@tmessi tmessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I wouldn't mind including a See footer in the commit message to point to the fix in go-secure-stdlib, ie:

See: https://github.com/hashicorp/go-secure-stdlib/commit/bf6d78ef5b727b83b2f8f41b473eb9764b446df4

@johanbrandhorst
Copy link
Collaborator Author

Looks good. I wouldn't mind including a See footer in the commit message to point to the fix in go-secure-stdlib, ie:

See: https://github.com/hashicorp/go-secure-stdlib/commit/bf6d78ef5b727b83b2f8f41b473eb9764b446df4

Good idea, done

@johanbrandhorst johanbrandhorst requested a review from tmessi June 28, 2022 18:58
@johanbrandhorst johanbrandhorst merged commit ed406e2 into main Jun 28, 2022
@johanbrandhorst johanbrandhorst deleted the jbrandhorst-bump-configutil branch June 28, 2022 19:12
@johanbrandhorst johanbrandhorst added this to the 0.9.1 milestone Jun 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants