feat(cli): add/set/remove worker tags #2266
Conversation
|
just the string parsing/initial flag stuff for now |
|
Can you add the new commands to internal/cmd/commands.go? And the following in internal/cmd/gencli/input.go |
… returning commands
… returning commands
|
Looks like we're going to hold off on merging this until @jefferai is back and can take a look |
… returning commands
… returning commands
|
|
||
| func extraFlagsHandlingFuncImpl(c *Command, _ *base.FlagSets, opts *[]workers.Option) bool { | ||
| switch c.Func { | ||
| case "add-worker-tags", "remove-worker-tags": |
There was a problem hiding this comment.
This is missing a set-worker-tags case.
There was a problem hiding this comment.
Do we want an empty -tag entry to convert to nil for set-worker-tags? I thought it was pretty nifty when boundary set-worker-tags -id w_idxxxxxxxx cleared the tags
There was a problem hiding this comment.
I added a set-worker-tags case with No tag supplied via -tag. Please use "-tag null" to clear all tags as the UI error when there is no -tag input
There was a problem hiding this comment.
Actually yeah I'm not sure what to do here since if I check whether c.FlagTags is empty, it overrides the "null" case--where I set target to nil for a stringSliceMapValue in flags.go--and returns an error.
I don't want to set a token entry for the map[string][]string to represent that its value should be nil, since that limits a valid key from use (even if it's a mapping like null=true). I don't like the idea of using an invalid key with commas like some form of ,,null,, since I think that's a bit confusing and unintuitive.
The most clear way forward might be creating another/using another existing bool to distinguish when the user inputs a "null" entry for set-worker-tags..
However, do I have to put a set-worker-tags case here? Is it alright for the user to be able to null the entry via boundary set-worker-tags -id w_idxxxxxxxx and boundary set-worker-tags -id w_idxxxxxxxx -tag null?
| @@ -546,13 +546,19 @@ func Parse(d string) (*Config, error) { | |||
| if !strutil.Printable(k) { | |||
| return nil, fmt.Errorf("Tag key %q contains non-printable characters", k) | |||
| } | |||
| if strings.Contains(k, ",") { | |||
There was a problem hiding this comment.
Not that this is necessarily wrong, but what's the reason for this?
There was a problem hiding this comment.
Since no commas are allowed thru the CLI entry, this applies the same standards to tag entries from the config file. Otherwise you can input keys such as "k3,k4" if you input them this way
tags {
key = ["val1", "val2"],
key2 = ["val1", "val2"],
"k3,k4" = ["vvv"],
}
example commands:
adding key with multiple values, adding multiple keys:
bin/boundary workers add-worker-tags -id w_1234567890 -tag key=val1,val2 -tag key2=valremoving a single tag:
bin/boundary workers remove-worker-tags -id w_1234567890 -tag key=val1setting all tags to nil:
bin/boundary workers set-worker-tags -id w_1234567890 -tag null