Skip to content

Commit

Permalink
testing: disable v2 linkage to nodes in integration tests (#19509)
Browse files Browse the repository at this point in the history
  • Loading branch information
rboyer authored Nov 3, 2023
1 parent 74daaa5 commit 6f4e037
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions testing/deployer/sprawl/catalog.go
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,16 @@ func (s *Sprawl) registerCatalogNode(
node *topology.Node,
) error {
if node.IsV2() {
return s.registerCatalogNodeV2(cluster, node)

// TODO(rb): nodes are optional in v2 and won't be used in k8s by
// default. There are some scoping issues with the Node Type in 1.17 so
// disable it for now.
//
// To re-enable you also need to link it to the Workload by setting the
// NodeName field.
//
// return s.registerCatalogNodeV2(cluster, node)
return nil
}
return s.registerCatalogNodeV1(cluster, node)
}
Expand Down Expand Up @@ -538,7 +547,8 @@ func serviceInstanceToResources(
Metadata: svc.Meta,
},
Data: &pbcatalog.Workload{
NodeName: node.PodName(),
// TODO(rb): disabling this until node scoping makes sense again
// NodeName: node.PodName(),
Identity: svc.ID.Name,
Ports: wlPorts,
Addresses: []*pbcatalog.WorkloadAddress{
Expand Down

0 comments on commit 6f4e037

Please # to comment.