Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pass signore client ID and secret to releaser #331

Merged
merged 2 commits into from
Aug 9, 2021
Merged

Conversation

mdeggies
Copy link
Member

@mdeggies mdeggies commented Jul 27, 2021

The release job is failing because the signore client ID and secret have not been set in the release job: https://github.com/hashicorp/go-getter/runs/3167243861. These are passed in to the setup-signore job, but it seems they also need to be made available explicitly in the goreleaser context. This PR is meant to address that.

@mdeggies mdeggies requested a review from milescrabill July 27, 2021 23:12
@bflad
Copy link
Contributor

bflad commented Jul 28, 2021

Setting the client id and secret in setup-signore should be creating a configuration file which can be used by later signore invocations, however that step is silently failing with:

(node:1577) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, open '/home/runner/.signore/config.yaml'

We should update the action to fail loudly for those errors (and of course resolve the issue itself 😄 ). A temporary workflow workaround may be to manually mkdir $HOME/.signore before setup-signore.

@mdeggies
Copy link
Member Author

Ah, thanks Brian! The secrets can also be set as env vars, right? (Though perhaps we'd need to set more than just the client ID + secret?) :-D

@milescrabill
Copy link
Member

Yes, the secrets can be set as env vars - SIGNORE_CLIENT_ID, SIGNORE_CLIENT_SECRET, SIGNORE_SIGNER, and more: https://github.com/hashicorp/signore/blob/main/docs/CONFIGURATION.md#client

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise this should be good to unblock the release process for now. 👍

Add Brian's magic.

Co-authored-by: Brian Flad <bflad417@gmail.com>
@mdeggies
Copy link
Member Author

mdeggies commented Aug 9, 2021

Ok! Merging & running attempt #2. Thanks y'all

@mdeggies mdeggies merged commit c926030 into main Aug 9, 2021
@mdeggies mdeggies deleted the signore-pass-secrets branch August 9, 2021 19:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants