Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix incompatibility between workload identity and managed identity auth #280

Merged
merged 6 commits into from
Feb 28, 2025

Conversation

sgmiller
Copy link
Collaborator

@sgmiller sgmiller commented Feb 28, 2025

The default credential provider does handle managed service identities, but can only get the client id from an env var. Supply it via env var (as there is no way in the Azure API to do so), but rely on the default credential provider to decide which auth pattern to use.

…ies, but can only get the client id from an env var. Supply it
@sgmiller sgmiller marked this pull request as draft February 28, 2025 17:08
@sgmiller sgmiller requested a review from a team February 28, 2025 19:31
@sgmiller sgmiller marked this pull request as ready for review February 28, 2025 19:31
@sgmiller sgmiller requested a review from a team February 28, 2025 19:35
@sgmiller
Copy link
Collaborator Author

Fixes hashicorp/vault#29717

Copy link
Collaborator

@jimlambrt jimlambrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I have a couple questions.

@sgmiller sgmiller merged commit da6aa5d into main Feb 28, 2025
18 of 20 checks passed
@sgmiller sgmiller deleted the sgm/fix-azure-auth-regression branch February 28, 2025 23:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants