Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: encountering expired items during the traversal process will result in zero values in the output. #163

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Fix: encountering expired items during the traversal process will result in zero values in the output. #163

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0b5e7b
add test case for expired values
DCjanus Dec 12, 2023
d6869bd
Revert "add test case for expired values"
DCjanus Dec 12, 2023
ec7949e
fix: prevent potential zero values.
DCjanus Dec 12, 2023
a66c313
clean expired entries in keys method
DCjanus Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions expirable/expirable_lru.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,11 +220,16 @@ func (c *LRU[K, V]) GetOldest() (key K, value V, ok bool) {
}

// Keys returns a slice of the keys in the cache, from oldest to newest.
// Expired entries are filtered out.
func (c *LRU[K, V]) Keys() []K {
c.mu.Lock()
defer c.mu.Unlock()
keys := make([]K, 0, len(c.items))
now := time.Now()
for ent := c.evictList.Back(); ent != nil; ent = ent.PrevEntry() {
if now.After(ent.ExpiresAt) {
continue
}
keys = append(keys, ent.Key)
}
return keys
Expand All @@ -235,15 +240,13 @@ func (c *LRU[K, V]) Keys() []K {
func (c *LRU[K, V]) Values() []V {
c.mu.Lock()
defer c.mu.Unlock()
values := make([]V, len(c.items))
i := 0
values := make([]V, 0, len(c.items))
now := time.Now()
for ent := c.evictList.Back(); ent != nil; ent = ent.PrevEntry() {
if now.After(ent.ExpiresAt) {
continue
}
values[i] = ent.Value
i++
values = append(values, ent.Value)
}
return values
}
Expand Down