(TF-19544) fix: Support reference completions with a trailing dot in object constructors #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
changed the title
ansgarm
force-pushed
the
fix-ref-completions-after-dot-in-objects
branch
from
4ea6da1
to
107393f
Compare
jpogran
reviewed
Aug 21, 2024
Good call! Yeah 👍 I'll rebase |
ansgarm
force-pushed
the
fix-ref-completions-after-dot-in-objects
branch
from
0267f45
to
8bb6cdb
Compare
ansgarm
force-pushed
the
fix-ref-completions-after-dot-in-objects
branch
from
8bb6cdb
to
7c543c8
Compare
Previously it was required to type a first character as the hclsyntax parser wouldn't return anything for these invalid references. This requires hashicorp/hcl#692 to work
ansgarm
force-pushed
the
fix-ref-completions-after-dot-in-objects
branch
from
7c543c8
to
f4ee4cc
Compare
…w includes the dot in the returned range
ansgarm
force-pushed
the
fix-ref-completions-after-dot-in-objects
branch
from
f4ee4cc
to
9cbeb16
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on hashicorp/hcl#692
117baa8