Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Evaluations can incur errors which Levant does not catch #39

Closed
jrasell opened this issue Nov 17, 2017 · 1 comment
Closed

Evaluations can incur errors which Levant does not catch #39

jrasell opened this issue Nov 17, 2017 · 1 comment
Assignees
@jrasell

Comments

@jrasell
Copy link
Member

jrasell commented Nov 17, 2017

When triggering a Nomad job registration; the evaluation can incur errors as seen below using the Nomad CLI:

==> Monitoring evaluation "a8a2fcf1"
    Evaluation triggered by job "traefik"
    Evaluation status changed: "pending" -> "complete"
==> Evaluation "a8a2fcf1" finished with status "complete" but failed to place all allocations:
    Task Group "traefik" (failed to place 4 allocations):
      * Resources exhausted on 1 nodes
      * Class "public" exhausted on 1 nodes
      * Dimension "network: bandwidth exceeded" exhausted on 1 nodes

When running this same registration through Levant all seems to go well:

[DEBUG] levant/templater: variable file not passed, using any passed CLI variables
[DEBUG] levant/deploy: running dynamic job count updater for job traefik
[INFO] levant/deploy: job traefik not running, using template file group counts
[INFO] levant/deploy: triggering a deployment of job traefik
[DEBUG] levant/deploy: job type system does not support Nomad deployment model
[INFO] levant/command: deployment of job traefik successful

Levant should therefore be updated to inspect the Nomad evaluation of a job deployment to catch these types of issues and provide feedback to the user.
@jrasell jrasell self-assigned this Nov 17, 2017
@ygersie
Copy link
Contributor

ygersie commented Nov 20, 2017

👍 This is fairly crucial

jrasell added a commit that referenced this issue Nov 20, 2017
@jrasell
Update Levant deployment to inspect the evaluation results.
25788d3 
Nomad can return an evaluation which has incurred errors due to
issues such as resource starvation. Previously Levant only
checked whether an actual API error was returned from the
evaluation call which meant errors during this phase were not
caught.

This change implaments an evaluation inspector which iterates
through any errors during an evaluation to provide this feedback
to the user.

Closes #39
@jrasell jrasell mentioned this issue Nov 20, 2017
Merged
@rbastiaans-tc rbastiaans-tc mentioned this issue Nov 9, 2022
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@jrasell jrasell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrasell @ygersie