Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

template: fix issue with default variables file not being used. #353

Merged
merged 1 commit into from
Aug 26, 2020
Merged

template: fix issue with default variables file not being used. #353

merged 1 commit into from
Aug 26, 2020

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Aug 25, 2020

No description provided.

@jrasell jrasell requested review from lgfa29 and cgbaker August 25, 2020 16:36
@jrasell jrasell self-assigned this Aug 25, 2020
cgbaker
cgbaker approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@cgbaker cgbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lgfa29
lgfa29 approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even with the diff it took me some time to spot the bug 🐛

@cgbaker
Copy link
Contributor

cgbaker commented Aug 25, 2020

Even with the diff it took me some time to spot the bug 🐛

same. had to expand and re-read it three times.

@jrasell jrasell merged commit c9ff2ba into master Aug 26, 2020
@jrasell jrasell deleted the fix-default-variable-file-use branch August 26, 2020 07:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cgbaker cgbaker cgbaker approved these changes

@lgfa29 lgfa29 lgfa29 approved these changes

Assignees

@jrasell jrasell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrasell @cgbaker @lgfa29