tests: add postgres integration tests #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimlambrt
force-pushed
the
jimlambrt-test-postgres
branch
from
f105826 to
1311ddb
Compare
|
I've merged #7 so we can merge this once it's reviewed/approved. |
johanbrandhorst
approved these changes
Aug 16, 2023
mgaffney
reviewed
Aug 16, 2023
Comment on lines
+31
to
+36
| func testDeleteUsers(t *testing.T, rw dbw.Writer) { | ||
| t.Helper() | ||
| testCtx := context.Background() | ||
| _, err := rw.Exec(testCtx, "delete from users", nil) | ||
| require.NoError(t, err) | ||
| } |
There was a problem hiding this comment.
It's used in the tests which would fail if it wasn't working.
There was a problem hiding this comment.
I don't see anything that calls it
There was a problem hiding this comment.
And the coverage report doesn't show it being called
There was a problem hiding this comment.
I'll remove it. Ty!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #7 includes WithPgPlaceholder() option(fa247ec) and we will wait for it to be merged, before updating the mql dependency in this PR and merging.