Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a -race enabled build to Travis #4620

Merged
merged 1 commit into from
Aug 31, 2018
Merged

Add a -race enabled build to Travis #4620

merged 1 commit into from
Aug 31, 2018

Conversation

schmichael
Copy link
Member

Allow it to fail for now with the goal of making it the default build in
the future.

Thanks to @jippi for calling attention to this in #4608. We should have added this build a long time ago so we could be race-free by now, but better late than never!

(If I get the .travis.yml right on the first try I'm giving myself a 🍪)

Allow it to fail for now with the goal of making it the default build in
the future.
@jippi
Copy link
Contributor

jippi commented Aug 28, 2018

Thanks @schmichael - will it be a 0.9 or 0.10 goal? all of those -race issues are imo critical bugs in production software, and should have importance than release schedules or new features - especially since its real issues in prod for me/users

@schmichael
Copy link
Member Author

schmichael commented Aug 28, 2018

@jippi We're not going to commit to 0 race detector failures by release X, but race failures in runtime code will be fixed for 0.9. Some of our tests are unfortunately racy in how they peek into internal state, and while we try to fix those as we come to them we're not going to hold up a release for non-runtime bugs.

0 race detector failures and the -race enabled build being the default is definitely our goal though.

@jippi
Copy link
Contributor

jippi commented Aug 29, 2018

@schmichael great - i totally agree with synth vs runtime errors

@schmichael schmichael merged commit 95855f0 into master Aug 31, 2018
@schmichael
Copy link
Member Author

(For the record I did manage to get the .travis.yml right on the first try! No cookies around though...)

@schmichael schmichael deleted the f-optional-race branch August 31, 2018 21:04
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants