Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #6159
Behavior
NOMAD_HOST_PORT_<label>
andNOMAD_PORT_<label>
are the same.NOMAD_PORT_<label>
gets set to the correct value from the port mapping, so the behavior matches 0.8.*Todo
rkt driverThe rkt driver in 0.8 wasn't setting port maps correctly, as it didn't implement
Prestart
driver config part [1]; see qemu[2] implementation for comparison[1] https://github.com/hashicorp/nomad/blob/v0.8.7/client/driver/rkt.go#L396-L398
[2] https://github.com/hashicorp/nomad/blob/v0.8.7/client/driver/qemu.go#L186-L205