UI: Fix layout of title component elements #8495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spacing has been broken for job types that use this yield (parameterised and periodic) since I added the exec button to this template. The grouping here may be subpar; another approach would be to yield contextual components (in the absence of named blocks) so invocations can specify which grouping to add to.
backspace
force-pushed
the
b-ui/job-page-title-layout
branch
from
7fa7908
to
cd11f26
Compare
Ember Asset Size actionAs of cd11f26 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
DingoEatingFuzz
approved these changes
Jul 22, 2020
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change:
After this change:
0.10.4:
The spacing has been off since I added the exec button but I didn’t notice until looking to confirm #8489. This is a quick fix that makes it less unsightly but doesn’t respect the logical grouping.