Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

UI: Change job search navigation to use id #8560

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

backspace
Copy link
Contributor

This fixes #8548. It was a significant oversight to use the
name instead of the id!

This fixes #8548. It was a significant oversight to use the
name instead of the id!
@github-actions
Copy link

Ember Asset Size action

As of b1ef9d1

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +3 B +3 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

Ember Test Audit comparison

master b1ef9d1 change
passes 1347 1347 0
failures 0 0 0
flaky 0 0 0
duration 6m 53s 364ms 6m 47s 769ms -05s 595ms

Copy link
Contributor

@DingoEatingFuzz DingoEatingFuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Sorry I didn't catch this in review.

@backspace backspace merged commit 11fb89d into master Jul 30, 2020
@backspace backspace deleted the b-ui/search-job-navigation branch July 30, 2020 14:10
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global search navigates to wrong job url when job name contains spaces
2 participants