Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Extra block device support #153

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Extra block device support #153

merged 2 commits into from
Apr 18, 2023

Conversation

lbajolet-hashicorp
Copy link
Contributor

This PR adds support for specifying extra block devices when creating an instance. This is done through one or more extra block_device blocks in the source definition.

Closes #7
Closes #10

@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner April 3, 2023 18:04
@nywilken nywilken self-assigned this Apr 3, 2023
@lbajolet-hashicorp lbajolet-hashicorp force-pushed the extra_block_device_support branch 3 times, most recently from 2c6c763 to 322f3f6 Compare April 4, 2023 20:37
nywilken
nywilken reviewed Apr 5, 2023
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. I left a few suggestions around documentation and code readability (in regards to conditionals). Please take a look at let me know what you think.

builder/googlecompute/config.go Outdated Show resolved Hide resolved
builder/googlecompute/block_device.go Outdated Show resolved Hide resolved
builder/googlecompute/block_device.go Outdated Show resolved Hide resolved
builder/googlecompute/config.go Show resolved Hide resolved
builder/googlecompute/driver.go Show resolved Hide resolved
builder/googlecompute/step_create_disks.go Outdated Show resolved Hide resolved
builder/googlecompute/block_device.go Outdated Show resolved Hide resolved
@lbajolet-hashicorp lbajolet-hashicorp force-pushed the extra_block_device_support branch from 322f3f6 to e5bc839 Compare April 18, 2023 19:05
nywilken
nywilken approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbajolet-hashicorp lbajolet-hashicorp merged commit fb2217d into main Apr 18, 2023
@lbajolet-hashicorp lbajolet-hashicorp deleted the extra_block_device_support branch April 18, 2023 20:53
@ericnorris ericnorris mentioned this pull request Oct 12, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees

@nywilken nywilken

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for google local-ssd [gogolecompute] Support for more than one disk
2 participants
@lbajolet-hashicorp @nywilken