feat: adds image_project_id parameter for pushing images to a different GCP project

[opdude]

This PR resurrects and rebases this PR which creates an image_project_id configuration option (which defaults to project_id) and allows defining a different project that an image should be created in.

Closes #30

[hashicorp-cla]

All committers have signed the CLA.

[lbajolet-hashicorp]

Hi @opdude,

Thanks for picking this one up! The code looks good to me, I just left a singe nit on an error message, but outside from that we're good I think.

Since this requires two projects to test the feature, I don't think we can easily add an acceptance test for this feature (I'll need to check what I can do on that front), have you confirmed it worked as you expect it to?

I'm pre-approving in advance since there's not a lot to change here, will circle back after you've addressed what I commented on.

Thanks again!

[lbajolet-hashicorp]

I presume you wanted to add the project ID in this log? If this is unaccessible I suggest we keep the previous message.

[opdude]

Ah this changed when debugging, intention was to remove this before commiting, have reverted it to the previous :)

[opdude]

Hi @opdude,

Thanks for picking this one up! The code looks good to me, I just left a singe nit on an error message, but outside from that we're good I think.

Since this requires two projects to test the feature, I don't think we can easily add an acceptance test for this feature (I'll need to check what I can do on that front), have you confirmed it worked as you expect it to?

I'm pre-approving in advance since there's not a lot to change here, will circle back after you've addressed what I commented on.

Thanks again!

Thanks. Yeah, I've been running it successfully both with and without using the override to the destination GCP project.

[lbajolet-hashicorp]

Hi @opdude,

Thanks for the quick reroll! I'll run tests and if they succeed, we can consider this done, I'll merge the PR when that happens.

Thanks again for picking this one up!

[ArmaanT]

Thanks for landing this @opdude! I'm glad to see these make it into main.

[bbitarelle]

Hi,

Thank you for this PR !
Just to clarify, we can now create images in another project, but not in 2 projects at the same time ?

Thanks !

[opdude]

Hi,

Thank you for this PR ! Just to clarify, we can now create images in another project, but not in 2 projects at the same time ?

Thanks !

Yes it stil only builds into a singular project but allows the building and destination project to be different.