Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix acceptance tests with local SSDs #198

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

lbajolet-hashicorp
Copy link
Contributor

Some machine types don't support local SSDs as extra block devices, so we change our acceptance tests that contain those so they use n2-* machines instead of E2-*, which don't support those block device attachments.

The acceptance tests for the builder that involve local SSDs don't work
on E2 instances anymore.

The documentation on GCE has been updated, and so are those tests, to an
N2 instance, which allows extra local SSDs to be attached.
Local SSDs are not available for all the instance types, so we call that
out in the docs, and add a link to the official documentation on that
subject.
@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner November 10, 2023 19:09
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@lbajolet-hashicorp lbajolet-hashicorp merged commit 90ac544 into main Nov 10, 2023
11 checks passed
@lbajolet-hashicorp lbajolet-hashicorp deleted the fix_acc_test_local_ssds branch November 10, 2023 19:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants