Image arch #234
Merged
Image arch #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbajolet-hashicorp
force-pushed
the
image_arch
branch
from
c5dc21c to
7eeb273
Compare
JenGoldstrich
approved these changes
Aug 7, 2024
When introduced, the `image_architecture` attribute defaulted to X86_64. This defaut was based on the assumption that the ARM64 images didn't default to that architecture, and instead if underfined that x86_64 was the default. This is not true, as if this is not defined when creating the image, the source image's architecture is inherited, so if the source image had its architecture set to ARM64, this would carry over. Therefore, the default value broke builds like those, as they would now point to x86_64 instead of carrying over the previous value. This commit then changes this default value, leaving it blank if unspecified, thereby restoring the old behaviour.
Since we plan on using this in tests, and the API already returns it, we include the architecture in the Image type from the common package, and set it within the drivers.
The image_architecture attribute when introduced caused problems with some existing configs, so to avoid introducing further bugs in the future, we add new accetpance tests that ensure the default value is maintained, and that the architecture is forwarded to the final image being created.
lbajolet-hashicorp
force-pushed
the
image_arch
branch
from
7eeb273 to
763ebaf
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #232 where the default value for
image_architecture(introduced in v1.1.5 of the plugin) defaulted to x86_64, thereby breaking some existing arm64 build configs.With this PR, we default again to leaving it empty, so the source image architecture gets forwarded to the final image being produced.
We also add some acceptance tests for this, so in the future we have an architecture to test those templates, and make sure we don't break it accidentally again.
Closes: #232