Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update goreleaser configuration to match other plugins #16

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

nywilken
Copy link
Contributor

@nywilken nywilken commented Jun 6, 2023

No description provided.

@nywilken nywilken requested a review from a team as a code owner June 6, 2023 20:20
.goreleaser.yml Outdated
mod_timestamp: '{{ .CommitTimestamp }}'
flags:
- -trimpath #removes all file system paths from the compiled executable
ldflags:
- '-s -w -X main.version={{.Version}} -X main.VersionPrerelease= '
- '-s -w -X {{ .ModulePath }}/version.Version={{.Version}} -X {{ .ModulePath }}/version.VersionPrerelease= '
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the version setting is incorrect here. I thought I left it intact. Thanks for the review @sylviamoss

@nywilken nywilken force-pushed the update/goreleaser branch from a394f5b to b256502 Compare August 1, 2023 18:14
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nywilken nywilken merged commit 84944af into main Aug 2, 2023
@nywilken nywilken deleted the update/goreleaser branch August 2, 2023 15:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants