Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updating comments for cache and config directories to be accurate #73

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

teddylear
Copy link
Contributor

@teddylear teddylear commented Jul 28, 2021

Addressing last comment from @azr on previous pr before it got merged to update comments to be more accurate and fix issues in comments. @azr Please let me know if there is anything else I should update with these comments.

Addresses: hashicorp/packer#9007

@teddylear teddylear marked this pull request as ready for review July 28, 2021 21:58
@teddylear teddylear requested a review from a team as a code owner July 28, 2021 21:58
Copy link
Contributor

@sylviamoss sylviamoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 I'll give @azr a change to review too before merging it.

Copy link
Contributor

@azr azr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for addressing this ! @teddylear LGTM !

@azr azr merged commit 39969ac into hashicorp:main Aug 4, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants