chore: Remove support for deprecated images configuration attribute in favor of image_files attribute in the export config block
#346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes deprecated `images` option that was noted to be removed over 2 years ago. - Updated export configuration descriptions. - Simplified `manifest` validation. - Updated to use `ui.Say` versus `ui.Message` for output consistency. - Added code comments. - Improved output and error messaging for output consistency. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
tenthirtyam
force-pushed
the
chore/update-export-step
branch
from
c83cb90 to
1fd59e3
Compare
nywilken
approved these changes
Dec 14, 2023
nywilken
changed the title
images configuration attribute in favor of image_files attribute in the export config block
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
imagesoption that was noted to be removed over 2 years ago.manifestvalidation.ui.Sayversusui.Messagefor output consistency.Tests