Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: upload max retries #379

Merged
merged 1 commit into from
Apr 3, 2024
Merged

feat: upload max retries #379

merged 1 commit into from
Apr 3, 2024

Conversation

tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Mar 6, 2024

Summary

  • Updates the vsphere post-processor to support max_retries for the upload to a vSphere endpoint. Defaults to 5.
  • Sets and uses constants for DefaultMaxRetries, DefaultDiskMode, and OvftoolWindows.

Reference

Closes #30

@tenthirtyam tenthirtyam self-assigned this Mar 6, 2024
@tenthirtyam tenthirtyam marked this pull request as ready for review March 6, 2024 05:23
@tenthirtyam tenthirtyam requested a review from a team as a code owner March 6, 2024 05:23
@tenthirtyam tenthirtyam marked this pull request as draft March 6, 2024 05:23
@tenthirtyam tenthirtyam added this to the v1.2.6 milestone Mar 7, 2024
@tenthirtyam tenthirtyam marked this pull request as ready for review March 15, 2024 00:45
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. I left a question and one possible suggestion. Please let me know what you think.

post-processor/vsphere/post-processor.go Outdated Show resolved Hide resolved
post-processor/vsphere/post-processor.go Outdated Show resolved Hide resolved
@tenthirtyam tenthirtyam marked this pull request as draft March 19, 2024 17:47
@tenthirtyam tenthirtyam force-pushed the feat-upload-max-retries branch 3 times, most recently from 2f690d0 to 1c1e3dd Compare April 2, 2024 19:22
- Updates the `vsphere` post-processor to support `max_retries` for the upload to a vSphere endpoint. Defaults to 5.
- Sets and uses constants for `DefaultMaxRetries`, `DefaultDiskMode`,
 and `OvftoolWindows`.

Ref: #30

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam tenthirtyam force-pushed the feat-upload-max-retries branch from 1c1e3dd to d3ea40c Compare April 2, 2024 19:28
@tenthirtyam tenthirtyam marked this pull request as ready for review April 2, 2024 19:30
@tenthirtyam tenthirtyam requested a review from nywilken April 2, 2024 19:30
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nywilken nywilken merged commit 0a8ddcd into main Apr 3, 2024
12 checks passed
@nywilken nywilken deleted the feat-upload-max-retries branch April 3, 2024 19:30
@hashicorp hashicorp locked and limited conversation to collaborators Jun 29, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for retries in vSphere post processor
2 participants