fix: ipv6 rfc2732 #406
Merged
fix: ipv6 rfc2732 #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use a literal IPv6 address in a URL, the literal address must be enclosed in "[" and "]" characters. ``` ssh example@[2010:836B:4179::836B:4179] ``` Refer to https://www.ietf.org/rfc/rfc2732. Ref: #333 Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
tenthirtyam
force-pushed
the
fix/ipv6-rfc2732
branch
from
4ff64e4 to
2ced8e8
Compare
nywilken
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
This looks good to me. Thanks for the fix.
Is there anything that needs to be updated in the docs for https://developer.hashicorp.com/packer/integrations/hashicorp/vsphere/latest/components/builder/vsphere-iso#wait-configuration
|
No changes are required in the docs. 😃 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To use a literal IPv6 address in a URL, the literal address must be enclosed in "
[" and "]" characters.Reference
Refer to https://www.ietf.org/rfc/rfc2732.
Closes: #333