Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: multiple network error msg #414

Merged
merged 1 commit into from
May 9, 2024

Conversation

tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Apr 26, 2024

Summary

  • Updates the error messages when more than one network with the same name resolves to more than one network.
  • Updated the documentation for network in vsphere-iso and vsphere-clone builders.

Testing

packer-plugin-vsphere git:(fix/multiple-network-error-msg) ✗ go fmt builder/vsphere/driver/vm.gopacker-plugin-vsphere git:(fix/multiple-network-error-msg) ✗ go fmt builder/vsphere/driver/network.go packer-plugin-vsphere git:(fix/multiple-network-error-msg) ✗ go fmt builder/vsphere/iso/step_create.gopacker-plugin-vsphere git:(fix/multiple-network-error-msg) ✗ go fmt builder/vsphere/clone/step_clone.gopacker-plugin-vsphere git:(fix/multiple-network-error-msg) ✗ make generate
2024/04/25 22:52:24 Copying "docs" to ".docs/"
2024/04/25 22:52:24 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...packer-plugin-vsphere git:(fix/multiple-network-error-msg) ✗ make buildpacker-plugin-vsphere git:(fix/multiple-network-error-msg) ✗ make test
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/examples/driver      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        2.117s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       4.388s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       6.576s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  4.647s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   7.780s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       3.234s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      4.134s

Reference

Ref: #237

- Updates the error messages when more than one network with the same name resolves to more than one network.
- Updated the documentation for `network` in `vsphere-iso` and `vsphere-clone` builders.

Ref: #237

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam added this to the v1.2.8 milestone Apr 26, 2024
@tenthirtyam tenthirtyam self-assigned this Apr 26, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 26, 2024 02:56
@tenthirtyam tenthirtyam added builder/vsphere-iso Builder: vsphere-iso builder/vsphere-clone Builder: vsphere-clone labels Apr 28, 2024
@lbajolet-hashicorp lbajolet-hashicorp merged commit d2db4c5 into main May 9, 2024
12 checks passed
@lbajolet-hashicorp lbajolet-hashicorp deleted the fix/multiple-network-error-msg branch May 9, 2024 13:43
@hashicorp hashicorp locked as resolved and limited conversation to collaborators Jun 29, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug builder/vsphere-clone Builder: vsphere-clone builder/vsphere-iso Builder: vsphere-iso
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants