fix: limit source vm to 15 char #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dilyar85 for review. |
tenthirtyam
force-pushed
the
fix/limit-source-vm-chars
branch
from
910387b to
7141f9b
Compare
- Updates `DefaultSourceNamePrefix` to "source". - Limits the name of the source virtual machine to 15 characters to support Windows. This was causing issues for deploying Windows VMs as they require a shorter hostname. #455 Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
tenthirtyam
force-pushed
the
fix/limit-source-vm-chars
branch
from
7141f9b to
c7dde39
Compare
dilyar85
approved these changes
Sep 30, 2024
|
LGTM, thanks for the fix! |
lbajolet-hashicorp
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
LGTM, thanks @tenthirtyam!
Out of curiosity, was this limit always active but undocumented, or is it something new to vsphere?
|
Note: nevermind, the commit message explains the rationale :) Merging now |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DefaultSourceNamePrefixto "source".Reference
Closes #455