Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build(deps): bump github.com/vmware/govmomi from 0.42.0 to 0.44.1 #476

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 11, 2024

Bumps github.com/vmware/govmomi from 0.42.0 to 0.44.1.

Release notes

Sourced from github.com/vmware/govmomi's releases.

v0.44.1

Release v0.44.1

Release Date: 2024-10-09

🐞 Fix

  • [05544f74] ensure proper vSAN URI format in ResolveLibraryItemStorage

🧹 Chore

  • [8234db49] Update version.go for v0.44.1

⚠️ BREAKING

📖 Commits

  • [8234db49] chore: Update version.go for v0.44.1
  • [05544f74] fix: ensure proper vSAN URI format in ResolveLibraryItemStorage

v0.44.0

Release v0.44.0

Release Date: 2024-10-07

🐞 Fix

  • [bf6e1626] synchronize access to session.Manager.userSession (#3571)

💡 Examples

  • [da37212c] add ExampleListView_ofContainerView

💫 API Changes

  • [733f1c0c] Update folder.PlaceVMsXCluster to support several placement types
  • [4665dff2] disable http.Transport.ForceAttemptHTTP2 by default (#3564)
  • [d95d3508] add vapi/crypto package with support for native KMS
  • [d2ccadf4] add rest.Client.DownloadAttachment method
  • [cb0453c9] extract NewDatastoreURL from Datastore.NewURL method
  • [9a02a4a9] Support querying PBM profile for IOFILTERS
  • [92797d40] Helpers for key management servers

💫 govc (CLI)

  • [844fa1cc] update help url

... (truncated)

Changelog

Sourced from github.com/vmware/govmomi's changelog.

Release v0.43.0

Release Date: 2024-09-10

🐞 Fix

  • [97aa7214] vcsim: avoid possible race when encoding PropertyCollector response
  • [ad2d3573] use complete InventoryPath in Datacenter.Folders

💫 API Changes

  • [476704a3] Fault helpers
  • [caad54aa] add VirtualMachine.AddDeviceWithProfile method
  • [a316da5c] VirtualMachine.AttachDisk unitNumber param is optional
  • [8491321a] ToString for vim types
  • [64610213] add namespace.RegisterVM binding
  • [e602029e] Fix panic when encoding nil iface ptrs to JSON

💫 govc (CLI)

  • [8fd86912] add disk.create '-profile' flag
  • [ea3cf257] add vm.disk.create '-profile' flag
  • [e73c34fa] add vm.disk.attach '-profile' flag
  • [06dcf31a] Add '-size' flag to datastore.create
  • [23390c23] add namespace.registervm command
  • [1892eecd] Support thick/eager disk opts on vm.create

💫 vcsim (Simulator)

  • [8421b678] Support PlaceVm with relocate placement type
  • [9234233e] Support PlaceVm with reconfigure placement type
  • [f06d0834] add VirtualMachine AttachDisk and DetachDisk methods
  • [35dc193f] Support VM crypto spec in vC Sim
  • [0517b87e] add namespace/registervm implementation

🧹 Chore

  • [b17abb20] Update version.go for v0.43.0
  • [93da4a20] sync generated govc/USAGE.md
  • [51105db8] govc: add common StorageProfileFlag

⚠️ BREAKING

VirtualMachine.AttachDisk unitNumber param is optional [a316da5c]: switching from int32 to *int32, otherwise the client must choose a valid unitNumber. vCenter will choose a unitNumber when not provided.

📖 Commits

... (truncated)

Commits
  • 8234db4 chore: Update version.go for v0.44.1
  • 05544f7 fix: ensure proper vSAN URI format in ResolveLibraryItemStorage
  • ff95505 chore: Update version.go for v0.44.0
  • f807c48 chore: fixup internal version
  • 5aff45e Merge pull request #3579 from vmware/dependabot/go_modules/golang.org/x/text-...
  • e2e45b8 Merge pull request #3584 from dougm/vcsim-view-manager-race
  • 7687bd3 Merge pull request #3583 from vmware/govc/update-help-url
  • 5a9567f vcsim: lock ViewManager in RegisterObject callbacks
  • 844fa1c govc: update help url
  • 131e69e Merge pull request #3578 from dougm/vcsim-object-update
  • Additional commits viewable in compare view

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
github.com/vmware/govmomi [< 0.35, > 0.34.0]
github.com/vmware/govmomi [< 0.37, > 0.36.2]
github.com/vmware/govmomi [>= 0.43.a, < 0.44]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner October 11, 2024 00:45
@tenthirtyam tenthirtyam force-pushed the dependabot/go_modules/github.com/vmware/govmomi-0.44.1 branch from 64fd2c0 to 1b295ed Compare October 11, 2024 00:53
@tenthirtyam tenthirtyam added this to the v1.4.1 milestone Oct 11, 2024
@tenthirtyam
Copy link
Collaborator

Note that I needed to run go mod tidy and it updated to:

go 1.22

toolchain go1.23.2

@RPitt
Copy link

RPitt commented Oct 15, 2024

ℹ️
Note that https://github.com/vmware/govmomi/releases/tag/v0.44.0 includes a desirable fix

this will massively improve ISO upload performance and other datastore operartions.
This has been degraded for some time, it might be worth an explicit call out in the release notes for the next release containing this.

FYI @tenthirtyam @lbajolet-hashicorp

Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments on the changes, mostly regarding the versions for the go toolchain and go.mod.
Aside from that, this LGTM!

go.mod Outdated Show resolved Hide resolved
.go-version Outdated Show resolved Hide resolved
Bumps [github.com/vmware/govmomi](https://github.com/vmware/govmomi) from 0.42.0 to 0.44.1.
- [Release notes](https://github.com/vmware/govmomi/releases)
- [Changelog](https://github.com/vmware/govmomi/blob/main/CHANGELOG.md)
- [Commits](vmware/govmomi@v0.42.0...v0.44.1)

---
updated-dependencies:
- dependency-name: github.com/vmware/govmomi
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@tenthirtyam tenthirtyam force-pushed the dependabot/go_modules/github.com/vmware/govmomi-0.44.1 branch from 1b295ed to 80f6f37 Compare October 15, 2024 18:43
@tenthirtyam tenthirtyam self-assigned this Oct 15, 2024
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tenthirtyam

@lbajolet-hashicorp lbajolet-hashicorp merged commit b167302 into main Oct 15, 2024
14 checks passed
@lbajolet-hashicorp lbajolet-hashicorp deleted the dependabot/go_modules/github.com/vmware/govmomi-0.44.1 branch October 15, 2024 19:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants