Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update unit test doc example in AWS provider #1272

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

drewmullen
Copy link
Contributor

The included example hasnt been updated since the code reorganization which includes the exporting of the Flatten function. Trying to figure it out took me a couple minutes... figured it might be helpful to someone to just update the docs

@drewmullen drewmullen requested a review from a team as a code owner November 8, 2023 16:03
@bflad bflad added the documentation Improvements or additions to documentation label Nov 9, 2023
@bflad bflad added this to the v2.30.0 milestone Nov 9, 2023
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @drewmullen 👋 Thank you for submitting this. I'm going to approve and merge this under best effort since I feel like you folks would know best if/when other developers might be referencing this particular example. If there is any sort of dependence on this documentation, it might be best if the content is moved into the AWS provider documentation since it is not guaranteed that this generic SDK documentation will always keep such a specific provider example. Thanks!

@bflad bflad merged commit fc72548 into hashicorp:main Nov 9, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2023
@drewmullen drewmullen deleted the fix-unit-test-example branch December 14, 2023 18:46
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants