Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Test Sweepers: Add sweepers for Lex resources #15439

Closed
gdavison opened this issue Oct 1, 2020 · 1 comment · Fixed by #18627
Closed

Test Sweepers: Add sweepers for Lex resources #15439

gdavison opened this issue Oct 1, 2020 · 1 comment · Fixed by #18627
Assignees
@bflad
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lexmodels Issues and PRs that pertain to the lexmodels service. technical-debt Addresses areas of the codebase that need refactoring or redesign.

Comments

@gdavison
Copy link
Contributor

gdavison commented Oct 1, 2020

Description

Implement a sweeper for Lex resources

Affected Resources

References
@gdavison gdavison added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 1, 2020
@ghost ghost added the service/lexmodels Issues and PRs that pertain to the lexmodels service. label Oct 1, 2020
@gdavison gdavison added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Oct 1, 2020
@bflad bflad self-assigned this Apr 7, 2021
bflad added a commit that referenced this issue Apr 7, 2021
@bflad
tests/service/lexmodelbuildingservice: Implement sweepers
6834bc3 
Reference: #15439

Output from sweeper in AWS Commercial:

```
2021/04/07 14:08:49 [DEBUG] Running Sweepers for region (us-west-2):
2021/04/07 14:08:49 [DEBUG] Running Sweeper (aws_lex_bot_alias) in region (us-west-2)
2021/04/07 14:08:50 [DEBUG] Running Sweeper (aws_lex_bot) in region (us-west-2)
2021/04/07 14:08:51 [DEBUG] Running Sweeper (aws_lex_intent) in region (us-west-2)
2021/04/07 14:11:47 [DEBUG] Running Sweeper (aws_lex_slot_type) in region (us-west-2)
2021/04/07 14:12:16 Sweeper Tests ran successfully:
        - aws_lex_bot_alias
        - aws_lex_bot
        - aws_lex_intent
        - aws_lex_slot_type
2021/04/07 14:12:16 [DEBUG] Running Sweepers for region (us-east-1):
2021/04/07 14:12:16 [DEBUG] Running Sweeper (aws_lex_bot_alias) in region (us-east-1)
2021/04/07 14:12:17 [DEBUG] Running Sweeper (aws_lex_bot) in region (us-east-1)
2021/04/07 14:12:17 [DEBUG] Running Sweeper (aws_lex_intent) in region (us-east-1)
2021/04/07 14:12:17 [DEBUG] Running Sweeper (aws_lex_slot_type) in region (us-east-1)
2021/04/07 14:12:17 Sweeper Tests ran successfully:
        - aws_lex_bot
        - aws_lex_intent
        - aws_lex_slot_type
        - aws_lex_bot_alias
ok      github.com/terraform-providers/terraform-provider-aws/aws       211.443s
```

Output from sweeper in AWS GovCloud (US):

```
2021/04/07 14:08:53 [DEBUG] Running Sweepers for region (us-gov-west-1):
2021/04/07 14:08:53 [DEBUG] Running Sweeper (aws_lex_bot_alias) in region (us-gov-west-1)
2021/04/07 14:08:55 [DEBUG] Running Sweeper (aws_lex_bot) in region (us-gov-west-1)
2021/04/07 14:08:56 [DEBUG] Running Sweeper (aws_lex_intent) in region (us-gov-west-1)
2021/04/07 14:08:56 [DEBUG] Running Sweeper (aws_lex_slot_type) in region (us-gov-west-1)
2021/04/07 14:08:57 Sweeper Tests ran successfully:
        - aws_lex_bot
        - aws_lex_intent
        - aws_lex_slot_type
        - aws_lex_bot_alias
ok      github.com/terraform-providers/terraform-provider-aws/aws       5.994s
```
@bflad bflad mentioned this issue Apr 7, 2021
Merged
bflad added a commit that referenced this issue Apr 9, 2021
@bflad @YakDriver
tests/service/lexmodelbuildingservice: Implement sweepers (#18627)
be849f3 
* tests/service/lexmodelbuildingservice: Implement sweepers

Reference: #15439

Output from sweeper in AWS Commercial:

```
2021/04/07 14:08:49 [DEBUG] Running Sweepers for region (us-west-2):
2021/04/07 14:08:49 [DEBUG] Running Sweeper (aws_lex_bot_alias) in region (us-west-2)
2021/04/07 14:08:50 [DEBUG] Running Sweeper (aws_lex_bot) in region (us-west-2)
2021/04/07 14:08:51 [DEBUG] Running Sweeper (aws_lex_intent) in region (us-west-2)
2021/04/07 14:11:47 [DEBUG] Running Sweeper (aws_lex_slot_type) in region (us-west-2)
2021/04/07 14:12:16 Sweeper Tests ran successfully:
        - aws_lex_bot_alias
        - aws_lex_bot
        - aws_lex_intent
        - aws_lex_slot_type
2021/04/07 14:12:16 [DEBUG] Running Sweepers for region (us-east-1):
2021/04/07 14:12:16 [DEBUG] Running Sweeper (aws_lex_bot_alias) in region (us-east-1)
2021/04/07 14:12:17 [DEBUG] Running Sweeper (aws_lex_bot) in region (us-east-1)
2021/04/07 14:12:17 [DEBUG] Running Sweeper (aws_lex_intent) in region (us-east-1)
2021/04/07 14:12:17 [DEBUG] Running Sweeper (aws_lex_slot_type) in region (us-east-1)
2021/04/07 14:12:17 Sweeper Tests ran successfully:
        - aws_lex_bot
        - aws_lex_intent
        - aws_lex_slot_type
        - aws_lex_bot_alias
ok      github.com/terraform-providers/terraform-provider-aws/aws       211.443s
```

Output from sweeper in AWS GovCloud (US):

```
2021/04/07 14:08:53 [DEBUG] Running Sweepers for region (us-gov-west-1):
2021/04/07 14:08:53 [DEBUG] Running Sweeper (aws_lex_bot_alias) in region (us-gov-west-1)
2021/04/07 14:08:55 [DEBUG] Running Sweeper (aws_lex_bot) in region (us-gov-west-1)
2021/04/07 14:08:56 [DEBUG] Running Sweeper (aws_lex_intent) in region (us-gov-west-1)
2021/04/07 14:08:56 [DEBUG] Running Sweeper (aws_lex_slot_type) in region (us-gov-west-1)
2021/04/07 14:08:57 Sweeper Tests ran successfully:
        - aws_lex_bot
        - aws_lex_intent
        - aws_lex_slot_type
        - aws_lex_bot_alias
ok      github.com/terraform-providers/terraform-provider-aws/aws       5.994s
```

* tests/resource/aws_lex_bot_alias: Remove extraneous AWS SDK Go pointer conversion in sweeper

* Apply suggestions from code review

Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com>

Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com>
@ghost
Copy link

ghost commented May 9, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 9, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@bflad bflad

Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lexmodels Issues and PRs that pertain to the lexmodels service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests/service/lexmodelbuildingservice: Implement sweepers hashicorp/terraform-provider-aws
2 participants
@bflad @gdavison