Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

data-source/aws_vpc: Refactor to use keyvaluetags library #10413

Merged
merged 1 commit into from
Oct 25, 2019
Merged

data-source/aws_vpc: Refactor to use keyvaluetags library #10413

merged 1 commit into from
Oct 25, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 7, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #7926

Release note for CHANGELOG:

NONE

In preparation for provider-wide ignore and default tag logic, here we refactor this resource to use the consistent keyvaluetags handling.

Output from acceptance testing:

--- PASS: TestAccDataSourceAwsVpc_basic (27.54s)
--- PASS: TestAccDataSourceAwsVpc_ipv6Associated (27.56s)
--- PASS: TestAccDataSourceAwsVpc_multipleCidr (51.12s)

@bflad
data-source/aws_vpc: Refactor to use keyvaluetags library
557d865 
Reference: #7926

In preparation for provider-wide ignore and default tag logic, here we refactor this resource to use the consistent `keyvaluetags` handling.

Output from acceptance testing:

```
--- PASS: TestAccDataSourceAwsVpc_basic (27.54s)
--- PASS: TestAccDataSourceAwsVpc_ipv6Associated (27.56s)
--- PASS: TestAccDataSourceAwsVpc_multipleCidr (51.12s)
```
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Oct 7, 2019
@bflad bflad requested a review from a team October 7, 2019 16:39
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Oct 7, 2019
ryndaniels
ryndaniels approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@ryndaniels ryndaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

--- PASS: TestAccDataSourceAwsVpc_ipv6Associated (10.81s)
--- PASS: TestAccDataSourceAwsVpc_basic (11.68s)
--- PASS: TestAccDataSourceAwsVpc_multipleCidr (31.31s)

@bflad bflad added this to the v2.34.0 milestone Oct 25, 2019
@bflad bflad merged commit 0996270 into master Oct 25, 2019
@bflad bflad deleted the td-aws_vpc-datasource-keyvaluetags branch October 25, 2019 15:02
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@ryndaniels ryndaniels ryndaniels approved these changes

Assignees
No one assigned
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v2.34.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @ryndaniels