Fix lambda provision id parser

[ericksoen]

Overview

This PR primarily encompasses three modifications that are delineated by each of the commits included in the PR:

1. Generate unique id for Lambda function name so that the tests can run in parallel
2. Support all the permitted variations of the function_name parameter value per the PutProvisionedConcurrencyConfig API documentation and update test cases
3. Use more explicit variable names, i.e., lambdaName instead of rName since the value is used as the function_name property for Lambda resource by the config generator

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11152

Release note for CHANGELOG:

resource/aws_lambda_provisioned_concurrency_config: Allow `function_arn` and `partial_arn` as valid `function_name` parameter values

Output from acceptance testing:

 make testacc TEST=./aws TESTARGS='-run=TestAccAWSLambdaProvisionedConcurrencyConfig'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaProvisionedConcurrencyConfig -timeout 120m
=== RUN   TestAccAWSLambdaProvisionedConcurrencyConfig_QualifierFunctionName
=== PAUSE TestAccAWSLambdaProvisionedConcurrencyConfig_QualifierFunctionName
=== RUN   TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaFunction
=== PAUSE TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaFunction
=== RUN   TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaProvisionedConcurrencyConfig
=== PAUSE TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaProvisionedConcurrencyConfig
=== RUN   TestAccAWSLambdaProvisionedConcurrencyConfig_ProvisionedConcurrentExecutions
=== PAUSE TestAccAWSLambdaProvisionedConcurrencyConfig_ProvisionedConcurrentExecutions
=== RUN   TestAccAWSLambdaProvisionedConcurrencyConfig_Qualifier_AliasName
=== PAUSE TestAccAWSLambdaProvisionedConcurrencyConfig_Qualifier_AliasName
=== CONT  TestAccAWSLambdaProvisionedConcurrencyConfig_QualifierFunctionName
=== CONT  TestAccAWSLambdaProvisionedConcurrencyConfig_Qualifier_AliasName
=== CONT  TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaProvisionedConcurrencyConfig
=== CONT  TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaFunction
=== CONT  TestAccAWSLambdaProvisionedConcurrencyConfig_ProvisionedConcurrentExecutions
--- PASS: TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaFunction (245.96s)
--- PASS: TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaProvisionedConcurrencyConfig (269.41s)
--- PASS: TestAccAWSLambdaProvisionedConcurrencyConfig_Qualifier_AliasName (397.47s)
--- PASS: TestAccAWSLambdaProvisionedConcurrencyConfig_ProvisionedConcurrentExecutions (400.98s)
--- PASS: TestAccAWSLambdaProvisionedConcurrencyConfig_QualifierFunctionName (518.61s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       529.681s

...

[ericksoen]

Force pushed a revision to the PR to reduce superfluous line changes due to variable renaming, parameter renaming etc. Revised test output is below:

$ TF_ACC=1 go test ./aws -v -count 1 -parallel 1 -run=TestAccAWSLambdaProvision
=== RUN   TestAccAWSLambdaProvisionedConcurrencyConfig_QualifierFunctionName
=== PAUSE TestAccAWSLambdaProvisionedConcurrencyConfig_QualifierFunctionName
=== RUN   TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaFunction
=== PAUSE TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaFunction
=== RUN   TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaProvisionedConcurrencyConfig
=== PAUSE TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaProvisionedConcurrencyConfig
=== RUN   TestAccAWSLambdaProvisionedConcurrencyConfig_ProvisionedConcurrentExecutions
=== PAUSE TestAccAWSLambdaProvisionedConcurrencyConfig_ProvisionedConcurrentExecutions
=== RUN   TestAccAWSLambdaProvisionedConcurrencyConfig_Qualifier_AliasName
=== PAUSE TestAccAWSLambdaProvisionedConcurrencyConfig_Qualifier_AliasName
=== CONT  TestAccAWSLambdaProvisionedConcurrencyConfig_QualifierFunctionName
--- PASS: TestAccAWSLambdaProvisionedConcurrencyConfig_QualifierFunctionName
=== CONT  TestAccAWSLambdaProvisionedConcurrencyConfig_ProvisionedConcurrentExe
=== CONT  TestAccAWSLambdaProvisionedConcurrencyConfig_Qualifier_AliasName
--- PASS: TestAccAWSLambdaProvisionedConcurrencyConfig_ProvisionedConcurrentExe
--- PASS: TestAccAWSLambdaProvisionedConcurrencyConfig_Qualifier_AliasName
=== CONT  TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaProvisi
--- PASS: TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaProvisi
=== CONT  TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaFunctio
--- PASS: TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaFunctio
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1616.31

[ericksoen]

Rebased this locally off main and fixed failing tests. Will push updates shortly.

[ericksoen]

Updated test results for the new code changes (includes unpushed change to change rName := acctest.RandomWithPrefix("tf-acc-test") to rName := fmt.Sprintf("%s-%s", "tf-acc-test", acctest.RandString(10)) to allow all tests to run in parallel):

$ make testacc TESTARGS='-run=TestAccAWSLambdaProvisionedConcurrencyConfig'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaProvisionedConcurrencyConfig -timeout 120m
=== RUN   TestAccAWSLambdaProvisionedConcurrencyConfig_QualifierFunctionName
=== PAUSE TestAccAWSLambdaProvisionedConcurrencyConfig_QualifierFunctionName
=== RUN   TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaFunction
=== PAUSE TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaFunction
=== RUN   TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaProvisionedConcurrencyConfig
=== PAUSE TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaProvisionedConcurrencyConfig
=== RUN   TestAccAWSLambdaProvisionedConcurrencyConfig_ProvisionedConcurrentExecutions
=== PAUSE TestAccAWSLambdaProvisionedConcurrencyConfig_ProvisionedConcurrentExecutions
=== RUN   TestAccAWSLambdaProvisionedConcurrencyConfig_Qualifier_AliasName
=== PAUSE TestAccAWSLambdaProvisionedConcurrencyConfig_Qualifier_AliasName
=== CONT  TestAccAWSLambdaProvisionedConcurrencyConfig_QualifierFunctionName
=== CONT  TestAccAWSLambdaProvisionedConcurrencyConfig_ProvisionedConcurrentExecutions
=== CONT  TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaProvisionedConcurrencyConfig
=== CONT  TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaFunction
=== CONT  TestAccAWSLambdaProvisionedConcurrencyConfig_Qualifier_AliasName
--- PASS: TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaProvisionedConcurrencyConfig (263.82s)
--- PASS: TestAccAWSLambdaProvisionedConcurrencyConfig_disappears_LambdaFunction (303.05s)
--- PASS: TestAccAWSLambdaProvisionedConcurrencyConfig_ProvisionedConcurrentExecutions (464.43s)
--- PASS: TestAccAWSLambdaProvisionedConcurrencyConfig_Qualifier_AliasName (760.67s)
--- PASS: TestAccAWSLambdaProvisionedConcurrencyConfig_QualifierFunctionName (769.54s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       770.787s

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[jar-b]

Hi @ericksoen - thanks for your effort on this patch! We opted for a different approach in #31933, migrating to the preferred comma-separated ID value. Unfortunately this meant we couldn't use this contribution, but we appreciate the submission. Thanks again!

[github-actions]

This functionality has been released in v5.4.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.