Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

resource/dynamodb_table: re-add logic to expand non_key_attributes configured in a TypeList #15195

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Sep 17, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15115

Release note for CHANGELOG:

resource/aws_dynamodb_table: correctly expand local_seconday_index.non_key_attributes

Output from acceptance testing:

--- PASS: TestAccAWSDynamoDbTable_lsiNonKeyAttributes (26.20s)

--- PASS: TestDiffDynamoDbGSI (0.00s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecificationValidation (16.14s)
--- PASS: TestAccAWSDynamoDbTable_disappears (54.95s)
--- PASS: TestAccAWSDynamoDbTableItem_withMultipleItems (55.61s)
--- PASS: TestAccAWSDynamoDbTableItem_basic (64.31s)
--- PASS: TestAccAWSDynamoDbTableItem_rangeKey (65.84s)
--- PASS: TestAccAWSDynamoDbTable_basic (76.59s)
--- PASS: TestAccAWSDynamoDbTable_tags (81.49s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdateValidation (18.65s)
--- PASS: TestAccAWSDynamoDbTableItem_updateWithRangeKey (104.31s)
--- PASS: TestAccAWSDynamoDbTableItem_update (105.96s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_PayPerRequestToProvisioned (109.80s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecification (113.14s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Enabled (62.49s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (124.25s)
--- PASS: TestAccAWSDynamoDbTable_enablePitr (124.59s)
--- PASS: TestAccAWSDynamoDbTable_disappears_PayPerRequestWithGSI (129.60s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_PayPerRequestToProvisioned (130.37s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes_emptyPlan (75.35s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Disabled (70.50s)
--- PASS: TestAccAWSDynamoDbTable_encryption (141.96s)
--- PASS: TestAccAWSDynamoDbTable_extended (365.67s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (351.24s)
--- PASS: TestAccAWSDynamoDbTable_Replica_Single (511.33s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (700.15s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdate (637.15s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_ProvisionedToPayPerRequest (863.35s)
--- PASS: TestAccAWSDynamoDbTable_Replica_Multiple (880.79s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_ProvisionedToPayPerRequest (1290.57s)

@anGie44 anGie44 requested a review from a team September 17, 2020 03:18
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/dynamodb Issues and PRs that pertain to the dynamodb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 17, 2020
@anGie44 anGie44 added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. labels Sep 17, 2020
@bflad bflad self-assigned this Sep 18, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for adding the test 🚀

Output from acceptance testing:

--- PASS: TestAccAWSDynamoDbTable_streamSpecificationValidation (15.89s)
--- PASS: TestAccAWSDynamoDbTable_disappears (47.14s)
--- PASS: TestAccAWSDynamoDbTableItem_basic (62.27s)
--- PASS: TestAccAWSDynamoDbTableItem_withMultipleItems (62.69s)
--- PASS: TestAccAWSDynamoDbTableItem_rangeKey (65.84s)
--- PASS: TestAccAWSDynamoDbTable_lsiNonKeyAttributes (70.96s)
--- PASS: TestAccAWSDynamoDbTable_basic (70.92s)
--- PASS: TestAccAWSDynamoDbTable_tags (83.72s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdateValidation (20.64s)
--- PASS: TestAccAWSDynamoDbTableItem_update (101.13s)
--- PASS: TestAccAWSDynamoDbTableItem_updateWithRangeKey (103.39s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecification (115.36s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_PayPerRequestToProvisioned (115.58s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Enabled (58.68s)
--- PASS: TestAccAWSDynamoDbTable_enablePitr (123.94s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (124.60s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_PayPerRequestToProvisioned (125.85s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes_emptyPlan (82.37s)
--- PASS: TestAccAWSDynamoDbTable_disappears_PayPerRequestWithGSI (130.99s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Disabled (68.74s)
--- PASS: TestAccAWSDynamoDbTable_encryption (143.19s)
--- PASS: TestAccAWSDynamoDbTable_extended (236.05s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (225.46s)
--- PASS: TestAccAWSDynamoDbTable_Replica_Single (467.00s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (567.81s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdate (502.91s)
--- PASS: TestAccAWSDynamoDbTable_Replica_Multiple (743.25s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_ProvisionedToPayPerRequest (1383.63s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_ProvisionedToPayPerRequest (1750.99s)

@anGie44 anGie44 added this to the v3.8.0 milestone Sep 18, 2020
@anGie44 anGie44 merged commit cafbe02 into master Sep 18, 2020
@anGie44 anGie44 deleted the b-dynamodb-table-non-key-attributes branch September 18, 2020 18:25
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 19, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/dynamodb Issues and PRs that pertain to the dynamodb service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_dynamodb_table: local secondary index definition not sending up NonKeyAttributes
2 participants