Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

r/aws_s3_bucket: Document and test replication to multiple destinations #16677

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Dec 9, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16546.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSS3Bucket_Replication_MultipleDestinations_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSS3Bucket_Replication_MultipleDestinations_ -timeout 120m
=== RUN   TestAccAWSS3Bucket_Replication_MultipleDestinations_EmptyFilter
=== PAUSE TestAccAWSS3Bucket_Replication_MultipleDestinations_EmptyFilter
=== RUN   TestAccAWSS3Bucket_Replication_MultipleDestinations_NonEmptyFilter
=== PAUSE TestAccAWSS3Bucket_Replication_MultipleDestinations_NonEmptyFilter
=== CONT  TestAccAWSS3Bucket_Replication_MultipleDestinations_EmptyFilter
=== CONT  TestAccAWSS3Bucket_Replication_MultipleDestinations_NonEmptyFilter
--- PASS: TestAccAWSS3Bucket_Replication_MultipleDestinations_EmptyFilter (39.33s)
--- PASS: TestAccAWSS3Bucket_Replication_MultipleDestinations_NonEmptyFilter (40.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	40.541s

@ewbankkit ewbankkit requested a review from a team as a code owner December 9, 2020 18:32
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/L Managed by automation to categorize the size of a PR. labels Dec 9, 2020
@ewbankkit ewbankkit changed the title r/aws_s3_bucket: Test replication to multiple destinations r/aws_s3_bucket: Document and test replication to multiple destinations Dec 29, 2020
Base automatically changed from master to main January 23, 2021 00:59
Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSS3Bucket_Replication_MultipleDestinations_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSS3Bucket_Replication_MultipleDestinations_ -timeout 120m
=== RUN   TestAccAWSS3Bucket_Replication_MultipleDestinations_EmptyFilter
=== PAUSE TestAccAWSS3Bucket_Replication_MultipleDestinations_EmptyFilter
=== RUN   TestAccAWSS3Bucket_Replication_MultipleDestinations_NonEmptyFilter
=== PAUSE TestAccAWSS3Bucket_Replication_MultipleDestinations_NonEmptyFilter
=== CONT  TestAccAWSS3Bucket_Replication_MultipleDestinations_EmptyFilter
=== CONT  TestAccAWSS3Bucket_Replication_MultipleDestinations_NonEmptyFilter
--- PASS: TestAccAWSS3Bucket_Replication_MultipleDestinations_EmptyFilter (39.33s)
--- PASS: TestAccAWSS3Bucket_Replication_MultipleDestinations_NonEmptyFilter (40.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	40.541s
@ewbankkit ewbankkit force-pushed the t-aws_s3_bucket-replication-multiple-destinations branch from c7c4eb4 to cb8cccf Compare February 10, 2021 18:01
@YakDriver YakDriver self-assigned this Feb 11, 2021
@YakDriver YakDriver force-pushed the t-aws_s3_bucket-replication-multiple-destinations branch from b0a6902 to 52d6b7e Compare February 11, 2021 14:46
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

GovCloud:

--- SKIP: TestAccAWSS3Bucket_Replication_MultipleDestinations_NonEmptyFilter (15.05s)
--- SKIP: TestAccAWSS3Bucket_Replication_MultipleDestinations_EmptyFilter (15.36s)
--- PASS: TestAccAWSS3Bucket_Replication_MultipleDestinations_TwoDestination (38.18s)

us-west-2:

--- PASS: TestAccAWSS3Bucket_Replication_MultipleDestinations_EmptyFilter (33.92s)
--- PASS: TestAccAWSS3Bucket_Replication_MultipleDestinations_NonEmptyFilter (34.39s)
--- PASS: TestAccAWSS3Bucket_Replication_MultipleDestinations_TwoDestination (34.49s)

@YakDriver YakDriver merged commit 06ae673 into hashicorp:main Feb 11, 2021
@YakDriver YakDriver added this to the v3.28.0 milestone Feb 11, 2021
@ewbankkit ewbankkit deleted the t-aws_s3_bucket-replication-multiple-destinations branch February 11, 2021 15:57
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 13, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon S3 Replication to multiple destinations
2 participants