Container network fixes

[mavogel]

will address

• docker_container's ip_address is empty when using network_mode #9
• terraform destroy always fails to remove a bridge network (endpoints still attached) #98
• Revert to allow network names in container network_mode #107

and is based on #50

[mkeeler]

This seems to break passing a network name in the "network_mode" configuration for a container. I like this change but it definitely should be considered a breaking change.

[mavogel]

@mkeeler this is coming from e07e383 which is already merged into the master. I guess network_mode was never intended to pass a network name. I wonder why it worked in the past. But you're right it's a breaking change

Update:

I guess network_mode was never intended to pass a network name

I was wrong ;) According to https://docs.docker.com/engine/api/v1.37/#operation/ContainerCreate

Network mode to use for this container. Supported standard values are: bridge, host, none, and container:<name|id>. Any other value is taken as a custom network's name to which this container should connect to

So I'll fix this breaking change before releasing in #107. Thx for pointing out!