Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bigtable: Update local gc_rules on read #12568

Conversation

modular-magician
Copy link
Collaborator

Currently when GCPolicy remote resource is updated not on TF (Pantheon, gcloud CLI, etc.), the gc_rules string are not updated on read. This PR fixes the issue by parsing the GC policy into JSON string that TF understands and set it in the local gc_rules. This hopefully will resolve the drift issue we have seen in KCC.

The original PR: GoogleCloudPlatform/magic-modules#6415 was created by hoangpham95.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigtable: added drift detection on `gc_rules` for `google_bigtable_gc_policy`

Derived from GoogleCloudPlatform/magic-modules#6526

* Update local gc_rules on read

* Early return + add comment

* Check list length

* Handle empty GC policy

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 3b0ae51 into hashicorp:main Sep 15, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2022
@modular-magician modular-magician deleted the downstream-pr-87e92f84a8f8488c2b2a7761039d781b1d42f29f branch November 17, 2024 03:35
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant