Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix documentation: #12592

Conversation

modular-magician
Copy link
Collaborator

  • fix formatting
  • add infortmation about minimal version requirements

Minor change to the documentation of the Location Policy and total size.
Current version has broken formatting and can be found here: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_node_pool#location_policy

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Tests re NO-OP since only documentation changes

Release Note Template for Downstream PRs (will be copied)

Docs fix

Derived from GoogleCloudPlatform/magic-modules#6571

* fix formatting
* add infortmation about minimal version requirements

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit aa5b60c into hashicorp:main Sep 19, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2022
@modular-magician modular-magician deleted the downstream-pr-306b97098bc55dfd61fa480231bbc7f8dbf2f794 branch November 17, 2024 00:12
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant