Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

google_vpc_access_connector missing GA args #12838

Conversation

modular-magician
Copy link
Collaborator

Closes #11934

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

vpcaccess - promoted `machine_type`, `min_instances`, `max_instances`, and `subnet` in `google_vpc_access_connector` to GA

Derived from GoogleCloudPlatform/magic-modules#6718

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 06eae6a into hashicorp:main Oct 19, 2022
brian-fogg-candid-health pushed a commit to candidhealth/terraform-provider-google that referenced this pull request Oct 21, 2022
…rp#12838)

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
brian-fogg-candid-health pushed a commit to candidhealth/terraform-provider-google that referenced this pull request Oct 24, 2022
…rp#12838)

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
@modular-magician modular-magician deleted the downstream-pr-a07f43d9e3accf964a424703eed1fb8da57a0ef8 branch November 17, 2024 02:51
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_vpc_access_connector is missing machine_type on stable despite being GA
1 participant