Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix condition in forceNewIfNetworkIPNotUpdatableFunc #19135

Conversation

modular-magician
Copy link
Collaborator

Resolves issue #16494

This function didn't work before.

d.HasChange will always return true in this condition because of this comparasion on the network field

https://www.googleapis.com/compute/v1/projects/iac-poc-krakow/global/networks/default
against
default

Release Note Template for Downstream PRs (will be copied)

compute: fixed force diff replacement logic for `network_ip` on resource `google_compute_instance`

Derived from GoogleCloudPlatform/magic-modules#11395

[upstream:8400c36d049b635bd63e1a79ae9229fa8c304c5c]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit e539a0d into hashicorp:main Aug 14, 2024
2 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2024
@modular-magician modular-magician deleted the downstream-pr-8400c36d049b635bd63e1a79ae9229fa8c304c5c branch November 17, 2024 01:43
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_compute_instance update network_interface.network_ip with google_compute_address
1 participant