Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix how conditions are handled in google_bigtable_instance_iam_* resources #19725

Conversation

modular-magician
Copy link
Collaborator

This PR

  1. Converts existing BigTable IAM acceptance tests to use the context pattern
  2. Updates BigTable IAM code to use policy version 3
  3. Adds new acceptance tests showing conditions can be used and imported

Release Note Template for Downstream PRs (will be copied)

bigtable: fixed an error where BigTable IAM resources could be created with conditions but the condition was not stored in state

Derived from GoogleCloudPlatform/magic-modules#11890

…sources (hashicorp#11890)

[upstream:54afca9967497515b718b8c4fcc0ef3fdb897f60]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 566cdbe into hashicorp:main Oct 2, 2024
2 checks passed
Copy link

github-actions bot commented Nov 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
@modular-magician modular-magician deleted the downstream-pr-54afca9967497515b718b8c4fcc0ef3fdb897f60 branch November 17, 2024 01:42
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant