Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix permadiff when Access Context Manager returns a different order for ingress / egress rule identities #20794

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Fix permadiff when Access Context Manager returns a different order for ingress / egress rule identities #20794

merged 1 commit into from
Dec 27, 2024

Conversation

modular-magician
Copy link
Collaborator

Adds a diff suppress func to ignore ordering for identities in ingress / egress rule resources. The order does not matter and sometimes the API changes it.

Addresses #19203 and #20519

accesscontextmanager: fixed permadiff due to reordering on `google_access_context_manager_service_perimeter_dry_run_egress_policy` `egress_from.identities`

accesscontextmanager: fixed permadiff due to reordering on `google_access_context_manager_service_perimeter_dry_run_ingress_policy` `ingress_from.identities`

accesscontextmanager: fixed permadiff due to reordering on `google_access_context_manager_service_perimeter_egress_policy` `egress_from.identities`

accesscontextmanager: fixed permadiff due to reordering on `google_access_context_manager_service_perimeter_ingress_policy` `ingress_from.identities`

Derived from GoogleCloudPlatform/magic-modules#12572

@modular-magician
Fix permadiff when Access Context Manager returns a different order f…
281a06f 
…or ingress / egress rule identities (hashicorp#12572)

Co-authored-by: Charlesleonius <charlesleon@google.com>

[upstream:d630fcf6c9ba4d98b4c0fe8afdb34f3ef2c2fb69]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner December 27, 2024 19:47
@modular-magician modular-magician merged commit 19cddf0 into hashicorp:main Dec 27, 2024
4 checks passed
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@modular-magician