Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix crash in manifest when configuration contains DynamicPseudotyped unknown values. #2055

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

alexsomesan
Copy link
Member

@alexsomesan alexsomesan commented Mar 21, 2023

Description

Fixes a crash in kubernetes_manifest when user configuration contains unknown values which also have unknown types, like the ones sometimes generated by the try(...) function.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

`resource/kubernetes_manifest: Fix crash when configuration contains unknown values of unknown type (DynamicPseudoType)

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@alexsomesan alexsomesan requested a review from a team as a code owner March 21, 2023 18:02
Copy link
Collaborator

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, weird issue! 🚀

@alexsomesan alexsomesan merged commit a4e09ba into main Mar 21, 2023
@alexsomesan alexsomesan deleted the fix-pseudotype-backfill branch March 21, 2023 19:18
@roshbhatia
Copy link

Thanks for fixing this @alexsomesan! I kept running into this yesterday -- any timeline on when this will make it into a release?

@jrhouston
Copy link
Collaborator

Next release is coming shortly @roshbhatia

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants