Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ldap dynamic credential data source #1833

Conversation

raymonstah
Copy link
Contributor

@raymonstah raymonstah commented May 1, 2023

Adds a data source for LDAP dynamic credentials.
Also renames the dynamic credentials resource to use mount instead of path, as discussed in a previous PR.

@raymonstah raymonstah requested a review from a team May 2, 2023 16:17
Co-authored-by: Milena Zlaticanin <60530402+Zlaticanin@users.noreply.github.com>
@Zlaticanin Zlaticanin self-requested a review May 2, 2023 22:11
Copy link
Contributor

@Zlaticanin Zlaticanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Had a few comments around handling the lease data and setting a unique ID, but should be ready to get in after those! 🙏🏼

@raymonstah raymonstah merged commit f9b182f into VAULT-8099/secrets/ldap May 3, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants