Retry Write on kv-v2 config #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinay-gopalan
approved these changes
Jul 26, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TFVP fails to create a KV secret backed when Vault is upgrading from kv-v1 to kv-v2 storage. The upgrade process is done async, so the provider should be able to retry the original request whenever the error is encountered.
This PR adds support for retrying create/update operations on the
vault_kv_secret_backend_v2resource.Example error:
"Error: error writing config data to kv_2/config, err=Error making API request.\n\nNamespace: foo\nURL: PUT https://localhost:8200/v1/kv_2/config\nCode: 400. Errors:\n\n* Waiting for the primary to upgrade from non-versioned to versioned data. This backend will be unavailable for a brief period and will resume service when the primary is finished."