Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add support for configuring SAML Auth resources #2053

Merged
merged 9 commits into from
Oct 31, 2023
Merged

Add support for configuring SAML Auth resources #2053

merged 9 commits into from
Oct 31, 2023

Conversation

vinay-gopalan
Copy link
Contributor

@vinay-gopalan vinay-gopalan commented Oct 12, 2023 •
edited
Loading

Description

Adds support for configuring the SAML Auth Backend as well as configuring SAML Auth Roles

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccSAMLAuthBackend_basic'
=== RUN   TestAccSAMLAuthBackend_basic
--- PASS: TestAccSAMLAuthBackend_basic (2.54s)
PASS


$ make testacc TESTARGS='-run=TestAccSAMLAuthBackendRole_basic'
=== RUN   TestAccSAMLAuthBackendRole_basic
--- PASS: TestAccSAMLAuthBackendRole_basic (2.64s)
PASS

@vinay-gopalan vinay-gopalan marked this pull request as ready for review October 13, 2023 21:57
@vinay-gopalan vinay-gopalan requested a review from a team October 13, 2023 21:57
@vinay-gopalan
Copy link
Contributor Author

Docs for the new resources should be up shortly.

@vinay-gopalan vinay-gopalan requested a review from a team October 30, 2023 22:18
@vinay-gopalan vinay-gopalan added this to the 3.22.0 milestone Oct 30, 2023
fairclothjm
fairclothjm reviewed Oct 31, 2023
View reviewed changes
website/docs/r/saml_auth_backend.html.md
# vault\_saml\_auth\_backend

Manages a SAML Auth mount in a Vault server. See the [Vault
documentation](https://www.vaultproject.io/docs/auth/saml/) for more
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this link to the Vault docs! I often wish all the TFVP resources did this because I usually want to cross reference.

fairclothjm
fairclothjm reviewed Oct 31, 2023
View reviewed changes
fairclothjm
fairclothjm approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we just need to remove a few duplicate lines in the changelog

@vinay-gopalan vinay-gopalan merged commit f7c9bdf into main Oct 31, 2023
@vinay-gopalan vinay-gopalan deleted the VAULT-20167/saml-auth branch October 31, 2023 16:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fairclothjm fairclothjm fairclothjm approved these changes

Assignees
No one assigned
Labels
documentation size/XL
Projects
None yet
Milestone
3.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vinay-gopalan @fairclothjm