Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add new WIF fields for GCP Secrets (Vault Enterprise only) #2249

Merged
merged 3 commits into from
May 29, 2024
Merged

Add new WIF fields for GCP Secrets (Vault Enterprise only) #2249

merged 3 commits into from
May 29, 2024

Conversation

vinay-gopalan
Copy link
Contributor

Description

Adds the following new fields to the GCP Secrets Backend resource to enable the WIF workflow:

  • identity_token_audience
  • identity_token_ttl
  • identity_token_key
  • service_account_email
  • accessor

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestGCPSecretBackend'
=== RUN   TestGCPSecretBackend
--- PASS: TestGCPSecretBackend (3.79s)
PASS

@vinay-gopalan vinay-gopalan requested review from a team and Zlaticanin and removed request for Zlaticanin May 28, 2024 23:37
@fairclothjm fairclothjm added this to the 4.3.0 milestone May 29, 2024
fairclothjm
fairclothjm approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few suggestions

vault/resource_gcp_secret_backend.go Outdated Show resolved Hide resolved
vault/resource_gcp_secret_backend.go Outdated Show resolved Hide resolved
@vinay-gopalan vinay-gopalan merged commit 9abe699 into main May 29, 2024
12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fairclothjm fairclothjm fairclothjm approved these changes

@Zlaticanin Zlaticanin Zlaticanin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vinay-gopalan @fairclothjm @Zlaticanin