db: add fields for skip auto rotation of static roles #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairclothjm
force-pushed
the
VAULT-31660/db-skip-static-role-import-rotation
branch
from
db6f700 to
d601371
Compare
fairclothjm
requested review from
kitography
and removed request for
kitography
vinay-gopalan
previously approved these changes
Jan 22, 2025
Yep! |
fairclothjm
force-pushed
the
VAULT-31660/db-skip-static-role-import-rotation
branch
from
e425d4e to
357f9ca
Compare
fairclothjm
force-pushed
the
VAULT-31660/db-skip-static-role-import-rotation
branch
from
78c4cdd to
3076681
Compare
vinay-gopalan
approved these changes
Feb 10, 2025
fairclothjm
deleted the
VAULT-31660/db-skip-static-role-import-rotation
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for skipping auto rotation of static roles.
We only support the role-level setting
skip_import_rotationand omit support for the config-level settingskip_static_role_import_rotation. This is because the config-level setting is always overridden by the role-level setting due to the bug with the Terraform SDK v2 described here. That bug forces the role-level setting to always be sent to Vault as an explicitskip_import_rotation=falsewhereas it should be sent as empty. This behavior causes the config-level setting to have no effect. Therefore, we will not support the config-level setting in TFVP because it does not function correctly. This is not ideal, however, the ability to set the feature at the role-level is sufficient for a user to be able to enable the feature.Vault PR: hashicorp/vault#29093
Once the feature is released in Vault 1.18.4 and the build matrix is updated, the failing test will pass.