Add support for SR-IOV network adapters

[andrew-lee-1089]

Description

When deploying a VM to a particular host you may want to attach a network adapter directly to an SR-IOV enabled physical NIC (bypassing a vSwitch)

To do this in the GUI, you simply attach a network adapter as normal and select 'SRIOV' instead of 'vmxnet3' (the default) and provide a link to the physical NIC. You still need to provide the name of a virtual network (from which you inherit various VLAN settings)

Potential Terraform Configuration

resource "vsphere_virtual_machine" "vm" {
   # ... other configuration ...
  host_system_id      = data.vsphere_host.host.id
  memory              = var.memory
  memory_reservation  = var.memory # Need to reserve memory for SR-IOV to work
  network_interface  {
    network_id        = data.vsphere_network.network.id
    adapter_type      = sriov
    physical_function = "0000:3b:00.1" 
  }
  ... other network_interfaces... 
}

Although there may be a natural extension to make a data type representing the physical NIC and the physical PCI is read off that data type (I think we can build off @bill-rich 's work in #1099

References

Th MOP to do this is here

This MOP is in two parts:

1. enable SR-IOV on the host: this MOP
2. Assign a Virtual Function as SR-IOV Passthrough Adapter to a Virtual Machine

This work essentially adds support for the second part of the MOP in terraform.

I've started work on this enhancement, and have a PR that does deploy the VM correctly but is hitting an issue with UnitNumber ordering see this issue

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[bill-rich]

Hi @andrew-lee-metaswitch! I responded on the govmomi issue, so please see there for further details, but I believe this can be supported by increasing our coverage of network interface types here.

[andrew-lee-1089]

Fixed in #1417

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

[tenthirtyam]

Reopening this issue as it's not yet merged. Once merged, this issue with be closed by the linked pull request.

Ryan Johnson
Staff II Solutions Architect | VMware, Inc.