feat: add support for sr-iov network interface

[vasilsatanasov]

Description

• Ported the code introduced with feat: Add support for SR-IOV Network Adapters #1417

• Verified that virtual machines with SR-IOV network adapters can be created

• Added basic e2e to verify that SR-IOV is supporte4d with ported code

• Verified that there are no regressions introduced ran TestAccResourceVSphereVirtualMachine_staticMAC
  TestAccResourceVSphereVirtualMachine_TestAccResourceVSphereVirtualMachine_hardwareVersionClone TestAccResourceVSphereVirtualMachine_disksKeepOnRemove TestAccResourceVSphereVirtualMachine_addDevices
  TestAccResourceVSphereVirtualMachine_highDiskUnitInsufficientBus TestAccResourceVSphereVirtualMachine_highDiskUnitNumbers TestAccResourceVSphereVirtualMachine_removeMiddleDevicesChangeDiskUnit TestAccResourceVSphereVirtualMachine_vAppIsoNoCdrom TestAccResourceVSphereVirtualMachine_vAppIsoBasic
  TestAccResourceVSphereVirtualMachine_vAppIsoChangeCdromBacking TestAccResourceVSphereVirtualMachine_cloneCustomizeWithNewResourcePool TestAccResourceVSphereVirtualMachine_cloneBlockESXi TestAccResourceVSphereVirtualMachine_clonePoweredOn TestAccResourceVSphereVirtualMachine_cloneWithBadSizeWithLinkedClone TestAccResourceVSphereVirtualMachine_cloneWithDifferentHostname TestAccResourceVSphereVirtualMachine_cpuHotAdd
  TestAccResourceVSphereVirtualMachine_dualStackIPv4AndIPv6 TestAccResourceVSphereVirtualMachine_hostVMotion

on the branch with the changes + same tests on the main branch with identical results

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccResourceVSphereVirtualMachine_SRIOV'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccResourceVSphereVirtualMachine_SRIOV -timeout 360m
?       github.com/hashicorp/terraform-provider-vsphere [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/administrationroles    [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/computeresource [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/contentlibrary  [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/customattribute [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/clustercomputeresource  [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/datastore       [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/dvportgroup     [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/envbrowse       [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/datacenter      [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/folder  [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/resourcepool    [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/hostsystem      [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/spbm    [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/ovfdeploy       [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/nsx     [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/storagepod      [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/network [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/structure       [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/testhelper      [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/utils   [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/vappcontainer   [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/provider        [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/virtualmachine  [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/vsanclient      [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/vsansystem      [no test files]
?       github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/vmworkflow     [no test files]
=== RUN   TestAccResourceVSphereVirtualMachine_SRIOV
--- PASS: TestAccResourceVSphereVirtualMachine_SRIOV (125.39s)
PASS
ok      github.com/hashicorp/terraform-provider-vsphere/vsphere 126.512s
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/viapi   0.865s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/virtualdisk     0.931s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/virtualdevice  1.091s [no tests to run]

Release Note

Release note for CHANGELOG:

Added support for SR-IOV network devices

References

Closes #1136
Closes #1417

[tenthirtyam]

Minor changes requested. Otherwise LGTM.

[tenthirtyam]

Minor text changes.

[tenthirtyam]

LGTM!

[github-actions]

This functionality has been released in v2.6.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

This functionality has been released in v2.6.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.