r/vsphere_file causes crash with incorrect configuration

[springer268]

Community Guidelines

• I have read and agree to the HashiCorp Community Guidelines .
• Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
• Do not leave "+1" or other comments that do not add relevant information or questions.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Terraform

v1.3.3

Terraform Provider

v2.2.0

VMware vSphere

7.0.2.00500

Description

I am trying to use vsphere_file to upload a file to a datastore. This causes a crash in the plugin

Affected Resources or Data Sources

r/vsphere_file

Terraform Configuration

provider "vsphere" {
  allow_unverified_ssl = true
  vsphere_server       = var.server
  user                 = var.user
  password             = var.password
}

resource "vsphere_file" "ubuntu_vmdk_upload2" {
  datacenter         = "dc"
  datastore          = "ds1"
  source_file        = "/Users/springern/Documents/hi.txt"
  destination_file   = "hi.txt"
  create_directories = true
}

Debug Output

https://gist.github.com/springer268/3ac854675994b18aa2922c042791c8dc

Panic Output

https://gist.github.com/springer268/3ac854675994b18aa2922c042791c8dc

(i dont see a crash.log)

Expected Behavior

The file to upload to the specified datastore

Actual Behavior

the file is not uploaded to the datastore and crashes the program

Steps to Reproduce

1. Have vsphere, terraform, and provider with matching versions
2. Attempt to upload file to datastore with configuration as shown before
3. See output

Environment Details

This error also occurs on a different vCenter.

The datastore is VMFS

Screenshots

No response

References

No response

[github-actions]

Hello, springer268! 🖐

Thank you for submitting an issue for this provider. The issue will now enter into the issue lifecycle.

If you want to contribute to this project, please review the contributing guidelines and information on submitting pull requests.

[tenthirtyam]

At first glance the example seems incorrect as it's set to create directories, but none are required as no directory path is provided.

resource "vsphere_file" "ubuntu_vmdk_upload2" {
  datacenter         = "dc"
  datastore          = "ds1"
  source_file        = "/Users/springern/Documents/hi.txt"
  destination_file   = "hi.txt"
  create_directories = true
}

Try:

resource "vsphere_file" "ubuntu_vmdk_upload2" {
  datacenter         = "dc"
  datastore          = "ds1"
  source_file        = "/Users/springern/Documents/hi.txt"
  destination_file   = "path/to/file/hi.txt"
  create_directories = true
}

or if in the datastore root:

resource "vsphere_file" "ubuntu_vmdk_upload2" {
  datacenter         = "dc"
  datastore          = "ds1"
  source_file        = "/Users/springern/Documents/hi.txt"
  destination_file   = "hi.txt"
  create_directories = false
}

[springer268]

Yes, this worked. I guess an error message should be added when this occurs, instead of a crash. Thanks.

[tenthirtyam]

I've updated the issue to track this item for an enhancement to misconfiguration error handling.

[github-actions]

This functionality has been released in v2.4.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.