Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adding vm_storage_policy_profile resource for tag based placement policy management #1094

Merged
merged 2 commits into from
Jun 7, 2020
Merged

Adding vm_storage_policy_profile resource for tag based placement policy management #1094

merged 2 commits into from
Jun 7, 2020

Conversation

sumitAgrawal007
Copy link
Contributor

@sumitAgrawal007 sumitAgrawal007 commented May 31, 2020 •
edited
Loading

Description

Adding VM_storage_policy_profile resource
CRUD operations for tag based placement policy rules

Acceptance tests

tag category acceptance test
https://gist.github.com/sumitAgrawal007/91ff0b3fe9af063de0deca85242f51cd

References

#993

@ghost ghost added size/xl Relative Sizing: Extra-Large documentation Type: Documentation labels May 31, 2020
bill-rich
bill-rich suggested changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just have a couple small adjustments.

vsphere/resource_vsphere_vm_storage_policy.go Outdated Show resolved Hide resolved
vsphere/resource_vsphere_vm_storage_policy.go Outdated Show resolved Hide resolved
vsphere/resource_vsphere_vm_storage_policy.go Outdated Show resolved Hide resolved
vsphere/resource_vsphere_vm_storage_policy.go Outdated Show resolved Hide resolved
website/docs/r/vm_storage_policy.html.markdown Outdated Show resolved Hide resolved
shylasrinivas
shylasrinivas suggested changes Jun 1, 2020
View reviewed changes
Copy link

@shylasrinivas shylasrinivas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetic changes required

@sumitAgrawal007 sumitAgrawal007 requested a review from bill-rich June 6, 2020 07:28
bill-rich
bill-rich approved these changes Jun 7, 2020
View reviewed changes
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the PR!

@bill-rich bill-rich merged commit 4971a0d into hashicorp:master Jun 7, 2020
@ghost
Copy link

ghost commented Jul 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 8, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@bill-rich bill-rich bill-rich approved these changes

@shylasrinivas shylasrinivas shylasrinivas approved these changes

Assignees
No one assigned
Labels
documentation Type: Documentation size/xl Relative Sizing: Extra-Large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumitAgrawal007 @bill-rich @shylasrinivas